You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/06/23 16:27:45 UTC
Re: Review Request 33263: Extended
SlaveTest.ShutdownUnregisteredExecutor test with a reason check.
> On April 23, 2015, 9:28 a.m., Till Toenshoff wrote:
> > Ship It!
>
> Till Toenshoff wrote:
> When testing your patch, I noticed that it fails for me.
> ```
> ../../src/tests/slave_tests.cpp:184: Failure
> Value of: status.get().reason()
> Actual: 8
> Expected: TaskStatus::REASON_COMMAND_EXECUTOR_FAILED
> Which is: 0
> ```
For me, too. This fails as indicated above every time. This needs a bit of work.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33263/#review81320
-----------------------------------------------------------
On April 16, 2015, 7:31 a.m., Andrey Dyatlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33263/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 7:31 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-2625
> https://issues.apache.org/jira/browse/MESOS-2625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check. Check that the reason is REASON_COMMAND_EXECUTOR_FAILED. According to the Slave::sendExecutorTerminatedStatusUpdate member function, this reason is expected instead of more general REASON_EXECUTOR_TERMINATED because the command executer is used in this test.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188
>
> Diff: https://reviews.apache.org/r/33263/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrey Dyatlov
>
>