You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/06 10:27:31 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #6496:
[AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends
on [AIRFLOW-5830] [AIRFLOW-5829]
mik-laj commented on a change in pull request #6496: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5830] [AIRFLOW-5829]
URL: https://github.com/apache/airflow/pull/6496#discussion_r342140291
##########
File path: breeze
##########
@@ -458,35 +475,47 @@ do
echo "Python version: ${PYTHON_VERSION}"
echo
shift 2 ;;
- -E|--env)
- export ENV="${2}";
- echo
- echo "Environment: ${ENV}"
- echo
- shift 2 ;;
-B|--backend)
export BACKEND="${2}";
echo
echo "Backend: ${BACKEND}"
echo
shift 2 ;;
- -K|--kubernetes-version)
- export KUBERNETES_VERSION="${2}";
+ -K|--start-kubernetes-cluster)
+ export START_KUBERNETES_CLUSTER="true";
+ export AIRFLOW_CONTAINER_FORCE_DOCKER_BUILD="true"
echo
- echo "Kubernetes version: ${KUBERNETES_VERSION}"
+ echo "Starting kubernetes cluster"
echo
- shift 2 ;;
+ shift ;;
+ -z|--recreate-kubernetes-cluster)
+ export RECREATE_KUBERNETES_CLUSTER="true";
+ echo
+ echo "Recreate kubernetes cluster"
+ echo
+ shift ;;
-M|--kubernetes-mode)
export KUBERNETES_MODE="${2}";
echo
echo "Kubernetes mode: ${KUBERNETES_MODE}"
echo
shift 2 ;;
+ -V|--kubernetes-version)
+ export KUBERNETES_VERSION="${2}";
+ echo
+ echo "Kubernetes version: ${KUBERNETES_VERSION}"
+ echo
+ shift 2 ;;
-s|--skip-mounting-local-sources)
SKIP_MOUNTING_LOCAL_SOURCES="true"
echo "Skip mounting local sources: ${SKIP_MOUNTING_LOCAL_SOURCES}"
echo
shift ;;
+ -N|--no-deps)
+ export AIRFLOW_CONTAINER_DEPS="false"
+ echo "Only run airflow-testing image without dependent images"
Review comment:
```diff
+ echo
echo "Only run airflow-testing image without dependent images"
```
For consistency. BTW. Do we need so many new lines? Maybe two at the beginning and end of the parse flags loop are enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services