[GitHub] [inlong] fuweng11 commented on a diff in pull request #8395: [INLONG-8394][Manager] TenantRole list interface support fuzzy match

["fuweng11 (via GitHub)" <gi...@apache.org>]

fuweng11 commented on code in PR #8395:
URL: https://github.com/apache/inlong/pull/8395#discussion_r1250209976


##########
inlong-manager/manager-dao/src/main/resources/mappers/TenantUserRoleEntityMapper.xml:
##########
@@ -64,8 +64,10 @@
         <if test="roleCode != null and roleCode != ''">
             and role_code = #{roleCode,jdbcType=VARCHAR}
         </if>
-        <if test="tenant != null and tenant != ''">
-            and tenant = #{tenant, jdbcType=VARCHAR}

Review Comment:
   Why delete it？



##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/user/TenantRolePageRequest.java:
##########
@@ -38,8 +38,8 @@ public class TenantRolePageRequest extends PageRequest {
     @ApiModelProperty(value = "Role code")
     private String roleCode;
 
-    @ApiModelProperty(value = "Tenant")
-    private String tenant;

Review Comment:
   Why delete it？
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org