You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/05 19:47:00 UTC
[jira] [Updated] (NETBEANS-3345) cleanup fallthrough warnings..
[ https://issues.apache.org/jira/browse/NETBEANS-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated NETBEANS-3345:
-------------------------------------
Labels: pull-request-available (was: )
> cleanup fallthrough warnings..
> ------------------------------
>
> Key: NETBEANS-3345
> URL: https://issues.apache.org/jira/browse/NETBEANS-3345
> Project: NetBeans
> Issue Type: Improvement
> Reporter: Brad Walker
> Assignee: Brad Walker
> Priority: Major
> Labels: pull-request-available
>
> There are numerous places in the code where the following warning is issued.
> {code:java}
> [repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:718: warning: [fallthrough] possible fall-through into case
> [repeat] case WS: //@import |
> [repeat] ^
> [repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:824: warning: [fallthrough] possible fall-through into case
> [repeat] default:
> [repeat] ^
> [repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:1015: warning: [fallthrough] possible fall-through into case
> [repeat] case mediaBody:
> [repeat] ^
> {code}
> I've looked over each and every place where this warning is emitted. The vast majority of these warnings are due to lexer spaghetti. Which happens often when dealing w/ look-ahead parsers..
> The simple fix is to add a "@SuppressWarnings("fallthrough")" to the method. as the code looks like the designer intended this behavior.
> There is one place where I did find a bug..
> _platform/core.network/src/org/netbeans/core/network/proxy/NetworkProxyReloader.java_
> It's missing a break statement in this file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists