You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/12/05 16:35:07 UTC

[GitHub] [zookeeper] brentwritescode commented on a change in pull request #1551: ZOOKEEPER-3943: Zookeeper Inspector throwing NullPointerExceptions and not displaying properly

brentwritescode commented on a change in pull request #1551:
URL: https://github.com/apache/zookeeper/pull/1551#discussion_r536819053



##########
File path: zookeeper-contrib/zookeeper-contrib-zooinspector/zooInspector.sh
##########
@@ -15,4 +15,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-java -cp "zookeeper-dev-ZooInspector.jar:lib/*:lib" org.apache.zookeeper.inspector.ZooInspector
+# Get the path to the directory containing this script
+SCRIPT_DIR=$(dirname "$0")
+
+# Get the path to the uber jar for this tool
+# (Requires "mvn install" or "mvn package" be run first)
+JAVA_LIB=`ls ${SCRIPT_DIR}/target/zookeeper-contrib-zooinspector-*-jar-with-dependencies.jar`

Review comment:
       That is a good point.  If we're only going to have a single JAR on the CLASSPATH then we might as well execute that JAR directly.  Let me try to make that change and update the PR.  Thanks for looking!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org