You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/02/24 18:41:04 UTC

[GitHub] [daffodil] stevedlawrence opened a new pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

stevedlawrence opened a new pull request #493:
URL: https://github.com/apache/daffodil/pull/493


   - Add new trait for info commands that are Seq's rather than simple
     values, implementing act() and diff() functions
   - Use this new trait to create a new "info suspensions" command to list
     the current suspensions. For example:
   
         (debug) info suspensions
           suspensions:
             SuppressableSeparatorUnparserSuspendableOperation for title
             RegionSplitSuspendableOperation for title
             SuppressableSeparatorUnparserSuspendableOperation for title
         (debug) info diff
           suspensions:
             + SuppressableSeparatorUnparserSuspendableOperation for title
   
   - Add a new "set diffExcludes" command to exclude info commands from
     showing up in "info diff". This can be useful if there are certain
     diffs that happen all the time that the user doesn't care about. For
     example:
   
         (debug) set diffExcludes bitPosition bitLimit suspensions
   
   - Skip debug steps during suspensions. This currently causes an abort
     (some suspension state should never be accessed), but also can cause
     confusing during debugging, especially related to diffs, since
     Daffodil temporarily time travel when evaluating suspensions. More
     thought is needed to figure out best how to debug suspensions so the
     time travel aspect is obvious and understandable.
   
   DAFFODIL-758


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence commented on pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #493:
URL: https://github.com/apache/daffodil/pull/493#issuecomment-785906588


   You might need to be logged in to codecov (proably via their Github auth method) for those links to work? I don't know why that's required but if I go to incognito mode or log out I get the same errors you see.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence merged pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #493:
URL: https://github.com/apache/daffodil/pull/493


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] tuxji commented on a change in pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
tuxji commented on a change in pull request #493:
URL: https://github.com/apache/daffodil/pull/493#discussion_r582817973



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala
##########
@@ -1842,6 +1908,32 @@ class InteractiveDebugger(runner: InteractiveDebuggerRunner, eCompilers: Express
         }
       }
 
+      object SetDiffExcludes extends DebugCommand {
+        val name = "diffExcludes"
+        val desc = "set info commands to exlude in the 'info diff' commanad"

Review comment:
       Fix typo in "exlude".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] tuxji commented on a change in pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
tuxji commented on a change in pull request #493:
URL: https://github.com/apache/daffodil/pull/493#discussion_r582839046



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala
##########
@@ -1842,6 +1908,32 @@ class InteractiveDebugger(runner: InteractiveDebuggerRunner, eCompilers: Express
         }
       }
 
+      object SetDiffExcludes extends DebugCommand {
+        val name = "diffExcludes"
+        val desc = "set info commands to exlude in the 'info diff' commanad"

Review comment:
       Hmm, I couldn't view any report data in your 493 link (the page said Unauthorized Github API: Forbidden Check on Codecov's status or see our docs for common support: Error 403).  I tried a report link from one of the build jobs' logs but the diff tab said "No files changed" so I couldn't see per-line coverage there either.  Not sure what's going on.  Here's the report link I tried.
   
   https://codecov.io/gh/apache/daffodil/commit/ba2d93f012bdff346c6f380a180c7ea3253bb5fb




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence commented on a change in pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #493:
URL: https://github.com/apache/daffodil/pull/493#discussion_r582825456



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala
##########
@@ -1842,6 +1908,32 @@ class InteractiveDebugger(runner: InteractiveDebuggerRunner, eCompilers: Express
         }
       }
 
+      object SetDiffExcludes extends DebugCommand {
+        val name = "diffExcludes"
+        val desc = "set info commands to exlude in the 'info diff' commanad"

Review comment:
       Will fix.
   
   Codecov seems a bit flakey to me. Sometimes comments/inline code shows up, sometimes they don't. And looking at the pull request there are a few lines that aren't covered:
   
   https://app.codecov.io/gh/apache/daffodil/compare/493/diff
   
   I'll see if I can tweak this test or add a new one to increase the coverage.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence commented on pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #493:
URL: https://github.com/apache/daffodil/pull/493#issuecomment-785869790


   This doesn't change how suspension deadlocks are displayed, only let's you see what suspensions are active during an unparse. All that deadlock output logic is unchanged. Yeah, a toStringForDebugger, or something similar, definitely seems needed to make this output a big more useful. What we currently have is useful to get an idea of what's going on, but if things are going wrong, and things like suspensions are blocked that you wouldn't expect to be, or for longer than you would expect, the current output doesn't help with that. This definitely isn't the last change for suspension info output.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] tuxji commented on a change in pull request #493: Add debugger "info suspensions" and "set diffExcludes" commands

Posted by GitBox <gi...@apache.org>.
tuxji commented on a change in pull request #493:
URL: https://github.com/apache/daffodil/pull/493#discussion_r582852333



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala
##########
@@ -1842,6 +1908,32 @@ class InteractiveDebugger(runner: InteractiveDebuggerRunner, eCompilers: Express
         }
       }
 
+      object SetDiffExcludes extends DebugCommand {
+        val name = "diffExcludes"
+        val desc = "set info commands to exlude in the 'info diff' commanad"

Review comment:
       Yes, you're right, I had to log into codecov on their home page.  Now both links work and show me line by line coverage changes although one aggregates all build jobs and the other is from only one build job.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org