[GitHub] [flink] KarmaGYZ commented on a change in pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

[GitBox <gi...@apache.org>]

KarmaGYZ commented on a change in pull request #18360:
URL: https://github.com/apache/flink/pull/18360#discussion_r785606436



##########
File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -316,6 +316,27 @@
                     .withDescription(
                             "The max number of completed jobs that can be kept in the job store.");
 
+    /** The type of job store that stores execution graph. */
+    @Documentation.Section(Documentation.Sections.ALL_JOB_MANAGER)
+    public static final ConfigOption<JobStoreType> JOB_STORE_TYPE =
+            key("jobstore.type")
+                    .enumType(JobStoreType.class)
+                    .defaultValue(JobStoreType.FILE)
+                    .withDescription(
+                            Description.builder()
+                                    .text(
+                                            "Determines which store implementation is used to store execution graph. Accepted values are:")
+                                    .list(
+                                            text("'FILE': use file to store execution graph"),

Review comment:
       ```suggestion
                                               text("'%s': use file to store execution graph", code(JobStoreType.FILE.name()),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org