[GitHub] [hudi] rahil-c commented on pull request #5391: [HUDI-3945] After the async compaction operation is complete, the task should exit

["rahil-c (via GitHub)" <gi...@apache.org>]

rahil-c commented on PR #5391:
URL: https://github.com/apache/hudi/pull/5391#issuecomment-1495127618

   @yihua @xiarixiaoyao  Wanted to get commmunity thoughts if this is safe to revert, I also tried the steps mentioned in the JIRA to see if this `sys.exit` is required https://issues.apache.org/jira/browse/HUDI-3945  but from my own repro without the sys exit call things are working fine similar to what @TengHuo mentioned
   
   The concern with this `sys.exit` call can be seen here mentioned in spark code  https://github.com/apache/spark/blob/v3.3.0/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala#L258 
   
   ```
    // If user application is exited ahead of time by calling System.exit(N), here mark
               // this application as failed with EXIT_EARLY. For a good shutdown, user shouldn't call
               // System.exit(0) to terminate the application.
   ```
   
   This is where the `ApplicationMaster: Final app status: FAILED, exitCode: 16, (reason: Shutdown hook called before final status was reported.)` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org