You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Filip Hanik - Dev Lists <de...@hanik.com> on 2009/01/31 01:44:46 UTC
svn repo layout for modules
ok, I was just about to tag the connection pool, and realized, I'm not
setup to do it.
I would suggest
https://svn.apache.org/repos/asf/tomcat/
- site
- tc6.0.x
- trunk
- modules <-- ADD THIS
- jdbc-pool
- trunk
- tags
- branches
- bayeux
- trunk
- tags
- branches
and move it away and out of (and get rid of) the tomcat/modules folder,
and let tomcat be tomcat.
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Costin Manolache <co...@gmail.com>.
On Tue, Feb 3, 2009 at 5:14 AM, Remy Maucherat <re...@apache.org> wrote:
> On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote:
> > I would suggest
> >
> > https://svn.apache.org/repos/asf/tomcat/
> > - site
> > - tc6.0.x
> > - trunk
> > - modules <-- ADD THIS
> > - jdbc-pool
> > - trunk
> > - tags
> > - branches
> > - bayeux
> > - trunk
> > - tags
> > - branches
> >
> > and move it away and out of (and get rid of) the tomcat/modules folder,
> > and let tomcat be tomcat.
>
> My suggestion is to dump modules as much as possible, this is messy.
> JDBC should really be developed elsewhere beyond the experimental stage
> (Tomcat is not a DB project, thanks) and Bayeux should go to the main
> tree (if it works).
Good points.
Costin
Re: svn repo layout for modules
Posted by Peter Rossbach <pr...@objektpark.de>.
What we and user need, is a real plugin and tool contribution area.
+1 to start the modules plugin system to create more value of the
tomcat project
regards,
Peter
Am 07.02.2009 um 01:18 schrieb Costin Manolache:
> On Fri, Feb 6, 2009 at 3:07 PM, Remy Maucherat <re...@apache.org>
> wrote:
>
>> On Fri, 2009-02-06 at 14:59 -0700, Filip Hanik - Dev Lists wrote:
>>> that discussion does exist if you look back into the archives
>>> what has changed since then?
>>
>> The proposed module layout looks so-so to me, and apparently
>> others feel
>> the same, so a solution is to remove the modules.
>
>
> Can we just leave the modules as they are - it really doesn't
> matter that
> much.
> Tagging is possible ( just tag the whole tree ), release is
> possible. The
> question of
> scope remains - but I see no problem with having a tomcat-specific
> jdbc pool
> or other
> components ( like we have juli and many other things that could fit
> commons
> better ),
> it it is maintained ( which makes it quite simple - if code is
> maintained
> mostly by tomcat,
> why not leave it in tomcat ? )
>
> I'm going to push the lite 'module' as well - modules dir seems a good
> middle ground.
>
> Costin
Re: svn repo layout for modules
Posted by Costin Manolache <co...@gmail.com>.
On Fri, Feb 6, 2009 at 3:07 PM, Remy Maucherat <re...@apache.org> wrote:
> On Fri, 2009-02-06 at 14:59 -0700, Filip Hanik - Dev Lists wrote:
> > that discussion does exist if you look back into the archives
> > what has changed since then?
>
> The proposed module layout looks so-so to me, and apparently others feel
> the same, so a solution is to remove the modules.
Can we just leave the modules as they are - it really doesn't matter that
much.
Tagging is possible ( just tag the whole tree ), release is possible. The
question of
scope remains - but I see no problem with having a tomcat-specific jdbc pool
or other
components ( like we have juli and many other things that could fit commons
better ),
it it is maintained ( which makes it quite simple - if code is maintained
mostly by tomcat,
why not leave it in tomcat ? )
I'm going to push the lite 'module' as well - modules dir seems a good
middle ground.
Costin
Re: svn repo layout for modules
Posted by Remy Maucherat <re...@apache.org>.
On Fri, 2009-02-06 at 14:59 -0700, Filip Hanik - Dev Lists wrote:
> that discussion does exist if you look back into the archives
> what has changed since then?
The proposed module layout looks so-so to me, and apparently others feel
the same, so a solution is to remove the modules.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Remy Maucherat wrote:
> On Fri, 2009-02-06 at 10:37 -0700, Filip Hanik - Dev Lists wrote:
>
>> ASF is community over code, its hard to grow the community if you never
>> add any code.
>> Tomcat JDBC would actually make TC 7 even more light weight since it is
>> smaller than DBCP.
>> Tomcat JDBC is not experimental either, its actually way more stable
>> than expected. Run it through let me know if you find any bugs.
>>
>
> Tomcat does Comet, so Bayeux is really directly related. You can still
> move it if you think it is not appropriate, though.
>
> OTOH, it seems obvious a DB pool is purely a database project. There is
> a DB project at the ASF already, and there's also commons, where you can
> propose your project as DBCP.next. Tomcat then ships it, replacing DBCP,
> which results in the same value for users.
>
that discussion does exist if you look back into the archives
what has changed since then?
Filip
> I think you can add code which is Servlet or JSP related, rather than
> about anything which could get shipped with Tomcat.
>
> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Remy Maucherat <re...@apache.org>.
On Fri, 2009-02-06 at 10:37 -0700, Filip Hanik - Dev Lists wrote:
> ASF is community over code, its hard to grow the community if you never
> add any code.
> Tomcat JDBC would actually make TC 7 even more light weight since it is
> smaller than DBCP.
> Tomcat JDBC is not experimental either, its actually way more stable
> than expected. Run it through let me know if you find any bugs.
Tomcat does Comet, so Bayeux is really directly related. You can still
move it if you think it is not appropriate, though.
OTOH, it seems obvious a DB pool is purely a database project. There is
a DB project at the ASF already, and there's also commons, where you can
propose your project as DBCP.next. Tomcat then ships it, replacing DBCP,
which results in the same value for users.
I think you can add code which is Servlet or JSP related, rather than
about anything which could get shipped with Tomcat.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Remy Maucherat wrote:
> On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote:
>
>> I would suggest
>>
>> https://svn.apache.org/repos/asf/tomcat/
>> - site
>> - tc6.0.x
>> - trunk
>> - modules <-- ADD THIS
>> - jdbc-pool
>> - trunk
>> - tags
>> - branches
>> - bayeux
>> - trunk
>> - tags
>> - branches
>>
>> and move it away and out of (and get rid of) the tomcat/modules folder,
>> and let tomcat be tomcat.
>>
>
> My suggestion is to dump modules as much as possible, this is messy.
> JDBC should really be developed elsewhere beyond the experimental stage
> (Tomcat is not a DB project, thanks) and Bayeux should go to the main
> tree (if it works).
>
That is a contradictory statement. Tomcat is not a DB project, nor is it
a Bayeux project.
So the reasoning above doesn't make any sense if you look at it that way.
Tomcat is no longer the reference implementation either.
So there is nothing that prevents us from providing value add components
as long as we are willing to maintain it.
ASF is community over code, its hard to grow the community if you never
add any code.
Tomcat JDBC would actually make TC 7 even more light weight since it is
smaller than DBCP.
Tomcat JDBC is not experimental either, its actually way more stable
than expected. Run it through let me know if you find any bugs.
So for modules, they are a good idea if we want to encourage people to
contribute to more areas.
as for the two modules, jdbc-pool and bayeux, I think they should still
be modules if we want to keep the core light and by being modules let us
fix bugs faster without releasing new versions of tomcat.
So from a code perspective you are right, from a community perspective
its not good at all to keep everything minimalistic.
Especially since you mentioned you wouldn't involve yourself in trunk,
then we are down by one resource. I would of course like for you to take
back that statement and rejoin in the efforts, despite differences, the
more is still the merrier
So I suggest to keep the modules here, mostly to encourage new
contributions to this project.
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Remy Maucherat <re...@apache.org>.
On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote:
> I would suggest
>
> https://svn.apache.org/repos/asf/tomcat/
> - site
> - tc6.0.x
> - trunk
> - modules <-- ADD THIS
> - jdbc-pool
> - trunk
> - tags
> - branches
> - bayeux
> - trunk
> - tags
> - branches
>
> and move it away and out of (and get rid of) the tomcat/modules folder,
> and let tomcat be tomcat.
My suggestion is to dump modules as much as possible, this is messy.
JDBC should really be developed elsewhere beyond the experimental stage
(Tomcat is not a DB project, thanks) and Bayeux should go to the main
tree (if it works).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Mark Thomas <ma...@apache.org>.
Filip Hanik - Dev Lists wrote:
> that would work for me, then the tag name could differentiate the module
> itself
Sounds good. The connectors use a similar approach so you'd have
asf/tomcat/tags/JDBC_POOL_0_0_1 or whatever.
Mark
>
> Filip
>
> Mark Thomas wrote:
>> How about adding .../tomcat/tags ?
>>
>> Mark
>>
>>
>> Filip Hanik - Dev Lists wrote:
>>
>>> Costin Manolache wrote:
>>>
>>>> It's getting spaghetti... If you really have to - no need to add
>>>> 'modules' -
>>>> just have them top-level ( i.e. under asf/tomcat ).
>>>>
>>> spaghetti is historical, all the directories from our older versions.
>>> this really boils down to dependencies.
>>> with the change in trunk to compile with JDK 1.6 (servlet spec
>>> requirement) it no longer makes sense for modules that can run under
>>> both tomcat 6, and future tomcat 7 to be part of tomcat-trunk
>>>
>>>> What prevents you from tagging ? Tag is cheap AFAIK - just tag the
>>>> entire
>>>> trunk.
>>>>
>>> nothing prevents me from tagging, but if I create 'tags' and 'branches'
>>> under tomcat/modules/jdbc-pool, then checking out tomcat, you will get
>>> everything, and that is a pain in the rear
>>>
>>>> I personally hate working with many small repos. I understand the need
>>>> when
>>>> you want different ACL and
>>>> people. I've seen projects with 10x more code and components than
>>>> tomcat
>>>> happily under one repo
>>>> ( and one source tree even ).
>>>>
>>> the entire ASF is under one repo, hence /repos/asf/...
>>>
>>>
>>>
>>>> Costin
>>>>
>>>> On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists
>>>> <devlists@hanik.com
>>>>
>>>>
>>>>> wrote:
>>>>>
>>>>
>>>>
>>>>> ok, I was just about to tag the connection pool, and realized, I'm not
>>>>> setup to do it.
>>>>>
>>>>> I would suggest
>>>>>
>>>>> https://svn.apache.org/repos/asf/tomcat/
>>>>> - site
>>>>> - tc6.0.x
>>>>> - trunk
>>>>> - modules <-- ADD THIS
>>>>> - jdbc-pool
>>>>> - trunk
>>>>> - tags
>>>>> - branches
>>>>> - bayeux
>>>>> - trunk
>>>>> - tags
>>>>> - branches
>>>>> and move it away and out of (and get rid of) the tomcat/modules
>>>>> folder,
>>>>> and let tomcat be tomcat.
>>>>>
>>>>> Filip
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>>
>>>>>
>>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
that would work for me, then the tag name could differentiate the module
itself
Filip
Mark Thomas wrote:
> How about adding .../tomcat/tags ?
>
> Mark
>
>
> Filip Hanik - Dev Lists wrote:
>
>> Costin Manolache wrote:
>>
>>> It's getting spaghetti... If you really have to - no need to add
>>> 'modules' -
>>> just have them top-level ( i.e. under asf/tomcat ).
>>>
>>>
>> spaghetti is historical, all the directories from our older versions.
>> this really boils down to dependencies.
>> with the change in trunk to compile with JDK 1.6 (servlet spec
>> requirement) it no longer makes sense for modules that can run under
>> both tomcat 6, and future tomcat 7 to be part of tomcat-trunk
>>
>>> What prevents you from tagging ? Tag is cheap AFAIK - just tag the entire
>>> trunk.
>>>
>>>
>> nothing prevents me from tagging, but if I create 'tags' and 'branches'
>> under tomcat/modules/jdbc-pool, then checking out tomcat, you will get
>> everything, and that is a pain in the rear
>>
>>> I personally hate working with many small repos. I understand the need
>>> when
>>> you want different ACL and
>>> people. I've seen projects with 10x more code and components than tomcat
>>> happily under one repo
>>> ( and one source tree even ).
>>>
>>>
>> the entire ASF is under one repo, hence /repos/asf/...
>>
>>
>>
>>> Costin
>>>
>>> On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists
>>> <devlists@hanik.com
>>>
>>>
>>>> wrote:
>>>>
>>>>
>>>
>>>
>>>> ok, I was just about to tag the connection pool, and realized, I'm not
>>>> setup to do it.
>>>>
>>>> I would suggest
>>>>
>>>> https://svn.apache.org/repos/asf/tomcat/
>>>> - site
>>>> - tc6.0.x
>>>> - trunk
>>>> - modules <-- ADD THIS
>>>> - jdbc-pool
>>>> - trunk
>>>> - tags
>>>> - branches
>>>> - bayeux
>>>> - trunk
>>>> - tags
>>>> - branches
>>>> and move it away and out of (and get rid of) the tomcat/modules folder,
>>>> and let tomcat be tomcat.
>>>>
>>>> Filip
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Mark Thomas <ma...@apache.org>.
How about adding .../tomcat/tags ?
Mark
Filip Hanik - Dev Lists wrote:
> Costin Manolache wrote:
>> It's getting spaghetti... If you really have to - no need to add
>> 'modules' -
>> just have them top-level ( i.e. under asf/tomcat ).
>>
> spaghetti is historical, all the directories from our older versions.
> this really boils down to dependencies.
> with the change in trunk to compile with JDK 1.6 (servlet spec
> requirement) it no longer makes sense for modules that can run under
> both tomcat 6, and future tomcat 7 to be part of tomcat-trunk
>> What prevents you from tagging ? Tag is cheap AFAIK - just tag the entire
>> trunk.
>>
> nothing prevents me from tagging, but if I create 'tags' and 'branches'
> under tomcat/modules/jdbc-pool, then checking out tomcat, you will get
> everything, and that is a pain in the rear
>> I personally hate working with many small repos. I understand the need
>> when
>> you want different ACL and
>> people. I've seen projects with 10x more code and components than tomcat
>> happily under one repo
>> ( and one source tree even ).
>>
> the entire ASF is under one repo, hence /repos/asf/...
>
>
>> Costin
>>
>> On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists
>> <devlists@hanik.com
>>
>>> wrote:
>>>
>>
>>
>>> ok, I was just about to tag the connection pool, and realized, I'm not
>>> setup to do it.
>>>
>>> I would suggest
>>>
>>> https://svn.apache.org/repos/asf/tomcat/
>>> - site
>>> - tc6.0.x
>>> - trunk
>>> - modules <-- ADD THIS
>>> - jdbc-pool
>>> - trunk
>>> - tags
>>> - branches
>>> - bayeux
>>> - trunk
>>> - tags
>>> - branches
>>> and move it away and out of (and get rid of) the tomcat/modules folder,
>>> and let tomcat be tomcat.
>>>
>>> Filip
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Costin Manolache wrote:
> It's getting spaghetti... If you really have to - no need to add 'modules' -
> just have them top-level ( i.e. under asf/tomcat ).
>
spaghetti is historical, all the directories from our older versions.
this really boils down to dependencies.
with the change in trunk to compile with JDK 1.6 (servlet spec
requirement) it no longer makes sense for modules that can run under
both tomcat 6, and future tomcat 7 to be part of tomcat-trunk
> What prevents you from tagging ? Tag is cheap AFAIK - just tag the entire
> trunk.
>
nothing prevents me from tagging, but if I create 'tags' and 'branches'
under tomcat/modules/jdbc-pool, then checking out tomcat, you will get
everything, and that is a pain in the rear
> I personally hate working with many small repos. I understand the need when
> you want different ACL and
> people. I've seen projects with 10x more code and components than tomcat
> happily under one repo
> ( and one source tree even ).
>
the entire ASF is under one repo, hence /repos/asf/...
> Costin
>
> On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists <devlists@hanik.com
>
>> wrote:
>>
>
>
>> ok, I was just about to tag the connection pool, and realized, I'm not
>> setup to do it.
>>
>> I would suggest
>>
>> https://svn.apache.org/repos/asf/tomcat/
>> - site
>> - tc6.0.x
>> - trunk
>> - modules <-- ADD THIS
>> - jdbc-pool
>> - trunk
>> - tags
>> - branches
>> - bayeux
>> - trunk
>> - tags
>> - branches
>> and move it away and out of (and get rid of) the tomcat/modules folder,
>> and let tomcat be tomcat.
>>
>> Filip
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn repo layout for modules
Posted by Costin Manolache <co...@gmail.com>.
It's getting spaghetti... If you really have to - no need to add 'modules' -
just have them top-level ( i.e. under asf/tomcat ).
What prevents you from tagging ? Tag is cheap AFAIK - just tag the entire
trunk.
I personally hate working with many small repos. I understand the need when
you want different ACL and
people. I've seen projects with 10x more code and components than tomcat
happily under one repo
( and one source tree even ).
Costin
On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists <devlists@hanik.com
> wrote:
> ok, I was just about to tag the connection pool, and realized, I'm not
> setup to do it.
>
> I would suggest
>
> https://svn.apache.org/repos/asf/tomcat/
> - site
> - tc6.0.x
> - trunk
> - modules <-- ADD THIS
> - jdbc-pool
> - trunk
> - tags
> - branches
> - bayeux
> - trunk
> - tags
> - branches
> and move it away and out of (and get rid of) the tomcat/modules folder,
> and let tomcat be tomcat.
>
> Filip
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>