You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 07:15:19 UTC

[GitHub] [arrow] sanjibansg commented on a diff in pull request #12791: ARROW-16113: [Python] Partitioning.dictionaries in case of a subset of fields are dictionary encoded

sanjibansg commented on code in PR #12791:
URL: https://github.com/apache/arrow/pull/12791#discussion_r842440413


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -549,7 +549,8 @@ def test_partitioning():
             pa.field('key', pa.float64())
         ])
     )
-    assert len(partitioning.dictionaries) == 0
+    assert len(partitioning.dictionaries) == 2
+    assert all(x is None for x in partitioning.dictionaries) is True

Review Comment:
   Made the change. Thanks for the suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org