[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6902: WIP: risc-v/mpfs: ihc: update vq ids

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6902:
URL: https://github.com/apache/incubator-nuttx/pull/6902#discussion_r952583795


##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -965,11 +965,11 @@ mpfs_rptun_get_resource(struct rptun_dev_s *dev)
       rsc->rpmsg_vring0.align       = VRING_ALIGN;
       rsc->rpmsg_vring0.num         = VRING_NR;
       rsc->rpmsg_vring0.da          = VRING0_DESCRIPTORS;
-      rsc->rpmsg_vring0.notifyid    = 0;
+      rsc->rpmsg_vring0.notifyid    = 1;
       rsc->rpmsg_vring1.align       = VRING_ALIGN;
       rsc->rpmsg_vring1.num         = VRING_NR;
       rsc->rpmsg_vring1.da          = VRING1_DESCRIPTORS;
-      rsc->rpmsg_vring0.notifyid    = 1;
+      rsc->rpmsg_vring0.notifyid    = 0;

Review Comment:
   it's better to initialize notifyid to RSC_NOTIFY_ID_ANY, so the framework will allocate the unique id for you automatically:
   https://github.com/OpenAMP/open-amp/blob/main/lib/remoteproc/rsc_table_parser.c#L131-L136



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org