You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/09 02:04:58 UTC
[kudu-CR] Fix various use-after-move errors
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7130
to review the following change.
Change subject: Fix various use-after-move errors
......................................................................
Fix various use-after-move errors
This fixes all of the cases where clang-tidy detects
'misc-use-after-move'. This is necessary before enabling protobuf move
constructors to avoid test failures.
Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
---
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/rpc/client_negotiation.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/util/status-test.cc
8 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/7130/1
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Fix various use-after-move errors
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Fix various use-after-move errors
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix various use-after-move errors
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7130
to look at the new patch set (#2).
Change subject: Fix various use-after-move errors
......................................................................
Fix various use-after-move errors
This fixes all of the cases where clang-tidy detects
'misc-use-after-move'. This is necessary before enabling protobuf move
constructors to avoid test failures.
Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
---
M build-support/lint.sh
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/rpc/client_negotiation.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/util/status-test.cc
9 files changed, 18 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/7130/2
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix various use-after-move errors
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Fix various use-after-move errors
......................................................................
Patch Set 3: Code-Review+2
sorry that was an unintentional rebase. I was trying to see whether rebasing over this patch would fix the flakiness on my unrelated patch.
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix various use-after-move errors
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix various use-after-move errors
......................................................................
Fix various use-after-move errors
This fixes all of the cases where clang-tidy detects
'misc-use-after-move'. This is necessary before enabling protobuf move
constructors to avoid test failures.
Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Reviewed-on: http://gerrit.cloudera.org:8080/7130
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/lint.sh
M src/kudu/client/client.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/rpc/client_negotiation.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/util/status-test.cc
9 files changed, 18 insertions(+), 17 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix various use-after-move errors
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix various use-after-move errors
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2895a3c334ee1f1e6c9d82d587973adf66ce3738
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No