You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/08/08 17:38:42 UTC
[native-toolchain-CR] IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20331
Change subject: IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
......................................................................
IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Boost locale has two implementations: one uses the ICU library
to implement locale support and the other uses only standard C++
libraries. Impala currently uses the non-ICU implementation.
However, if ICU is installed before Boost is built, then Boost
will use it by default. This leads to link errors, because the
Impala build doesn't link in ICU.
This passes the boost.locale.icu=off flag to the Boost build
to force it to build the non-ICU implementation even if ICU
is installed. This is important to the ARM core job.
Testing:
- Ran an ARM core job with this custom native-toolchain
- Ran a normal toolchain build
Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
---
M source/boost/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/31/20331/1
--
To view, visit http://gerrit.cloudera.org:8080/20331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
Gerrit-Change-Number: 20331
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20331 )
Change subject: IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
......................................................................
IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Boost locale has two implementations: one uses the ICU library
to implement locale support and the other uses only standard C++
libraries. Impala currently uses the non-ICU implementation.
However, if ICU is installed before Boost is built, then Boost
will use it by default. This leads to link errors, because the
Impala build doesn't link in ICU.
This passes the boost.locale.icu=off flag to the Boost build
to force it to build the non-ICU implementation even if ICU
is installed. This is important to the ARM core job.
Testing:
- Ran an ARM core job with this custom native-toolchain
- Ran a normal toolchain build
Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
Reviewed-on: http://gerrit.cloudera.org:8080/20331
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M source/boost/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Smith: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
Gerrit-Change-Number: 20331
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20331 )
Change subject: IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
......................................................................
Patch Set 1: Verified+1
An ARM native toolchain job passed and the usual x86 docker toolchain job passed. Going ahead with this.
--
To view, visit http://gerrit.cloudera.org:8080/20331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
Gerrit-Change-Number: 20331
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Aug 2023 00:54:03 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20331 )
Change subject: IMPALA-12346: Explicitly disable ICU dependency for Boost locale build
......................................................................
Patch Set 1: Code-Review+2
I've used this in some of my testing too.
--
To view, visit http://gerrit.cloudera.org:8080/20331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b
Gerrit-Change-Number: 20331
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Aug 2023 17:40:33 +0000
Gerrit-HasComments: No