You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/20 14:00:19 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request #5882: [UI] fix delete domain
JoaoJandre opened a new pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882
### Description
When deleting a domain, the UI shows an error, but successfully deletes the domain. This happens because the UI does not refresh the domain list and requests the deleted domain's information, thus ACS would return an error. This was partially fixed on PR #5710, but the changes were insufficient.
In case there is only 2 domains, for example: 'ROOT' and 'A', when deleting 'A' the UI does not show the previous error, but it still shows the deleted domain's information. The proposed solution to this problem is to force the UI to refresh the component that shows the domain information. Therefore, this PR is intended to introduce these changes.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### How Has This Been Tested?
This was tested in a local lab:
- Make the domain list have only the ROOT and any other domain;
- Delete the domain;
- The ROOT information should be shown, and the ROOT should be selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018193786
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5882 (SL-JID-1045)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1036558498
Merging this one base in the approvals and test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1017600950
Hi @JoaoJandre Can you rebase this PR with 4.16 please. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
GutoVeronezi merged pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018063479
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018191120
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018460626
> > Hi @JoaoJandre Can you rebase this PR with 4.16 please. Thanks.
>
> If it only goes to main its ok for me :)
The PR #5710 changes are into 4.16.1 already. If you rebase this with 4.16, I'll forward merge the changes to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018442424
> Hi @JoaoJandre Can you rebase this PR with 4.16 please. Thanks.
If it only goes to main its ok for me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018465026
> > > Hi @JoaoJandre Can you rebase this PR with 4.16 please. Thanks.
> >
> >
> > If it only goes to main its ok for me :)
>
> The PR #5710 changes are into 4.16.1 already. If you rebase this with 4.16, I'll forward merge the changes to main.
I see, thanks for the tip, but to me it is fine going to main only. We do not use those minor versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5882: [UI] fix delete domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5882:
URL: https://github.com/apache/cloudstack/pull/5882#issuecomment-1018468017
> > > > Hi @JoaoJandre Can you rebase this PR with 4.16 please. Thanks.
> > >
> > >
> > > If it only goes to main its ok for me :)
> >
> >
> > The PR #5710 changes are into 4.16.1 already. If you rebase this with 4.16, I'll forward merge the changes to main.
>
> I see, thanks for the tip, but to me it is fine going to main only. We do not use those minor versions.
ok @JoaoJandre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org