You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/10/07 16:29:31 UTC
[superset] branch use-gsheet-enum-catalog created (now caab009a86)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch use-gsheet-enum-catalog
in repository https://gitbox.apache.org/repos/asf/superset.git
at caab009a86 cleanup
This branch includes the following new commits:
new caab009a86 cleanup
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: cleanup
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch use-gsheet-enum-catalog
in repository https://gitbox.apache.org/repos/asf/superset.git
commit caab009a8621e9cc7c1c04e174b1da4fc1adb003
Author: hughhhh <hu...@gmail.com>
AuthorDate: Fri Oct 7 12:24:50 2022 -0400
cleanup
---
.../src/views/CRUD/data/database/DatabaseModal/index.tsx | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
index a2ca444752..37c13f17e5 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -744,11 +744,11 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
engine_information,
},
});
- }
- if (database_name === 'Google Sheets') {
- // only create a catalog if the DB is Google Sheets
- setDB({ type: ActionType.addTableCatalogSheet });
+ if (engine === Engines.GSheet) {
+ // only create a catalog if the DB is Google Sheets
+ setDB({ type: ActionType.addTableCatalogSheet });
+ }
}
};