You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/08/10 00:53:48 UTC

(skywalking-banyandb) branch main updated: Fix flaky TestPropertyInspect by awaiting liaison info (#1260)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git


The following commit(s) were added to refs/heads/main by this push:
     new aca1bf994 Fix flaky TestPropertyInspect by awaiting liaison info (#1260)
aca1bf994 is described below

commit aca1bf9945a2e73029fffc768e25016a77374afa
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Mon Aug 10 08:53:42 2026 +0800

    Fix flaky TestPropertyInspect by awaiting liaison info (#1260)
---
 test/integration/distributed/inspection/common.go | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/test/integration/distributed/inspection/common.go b/test/integration/distributed/inspection/common.go
index 9a026c646..a75f99b46 100644
--- a/test/integration/distributed/inspection/common.go
+++ b/test/integration/distributed/inspection/common.go
@@ -445,13 +445,15 @@ var _ = ginkgo.Describe("Inspect stream in distributed mode", func() {
 	})
 
 	ginkgo.It("should return liaison info", func() {
-		ginkgo.By("Inspecting stream group")
-		resp, err := groupClient.Inspect(ctx, &databasev1.GroupRegistryServiceInspectRequest{Group: groupName})
-		gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
-		gomega.Expect(resp).NotTo(gomega.BeNil())
-
-		ginkgo.By("Verifying stream liaison info collected")
-		gomega.Expect(len(resp.LiaisonInfo)).Should(gomega.BeNumerically(">=", 1), "should collect from at least one liaison node")
+		ginkgo.By("Waiting for stream liaison info to be collected")
+		var resp *databasev1.GroupRegistryServiceInspectResponse
+		gomega.Eventually(func(g gomega.Gomega) {
+			inspectResp, inspectErr := groupClient.Inspect(ctx, &databasev1.GroupRegistryServiceInspectRequest{Group: groupName})
+			g.Expect(inspectErr).ShouldNot(gomega.HaveOccurred())
+			g.Expect(inspectResp).NotTo(gomega.BeNil())
+			g.Expect(len(inspectResp.LiaisonInfo)).Should(gomega.BeNumerically(">=", 1), "should collect from at least one liaison node")
+			resp = inspectResp
+		}, flags.EventuallyTimeout).Should(gomega.Succeed())
 
 		for idx, liaisonInfo := range resp.LiaisonInfo {
 			logger.Infof("Inspecting stream liaison node %d: PendingWrite=%d, PendingSync=%d parts",