[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #909: HDDS-3416. Enable TestSCMNodeManager#testScmStatsFromNodeReport

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #909:
URL: https://github.com/apache/hadoop-ozone/pull/909#discussion_r425309321



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
##########
@@ -855,6 +860,10 @@ public void testScmStatsFromNodeReport()
         String storagePath = testDir.getAbsolutePath() + "/" + dnId;
         StorageReportProto report = TestUtils
             .createStorageReport(dnId, storagePath, capacity, used, free, null);
+        NodeReportProto nodeReportProto = TestUtils.createNodeReport(report);
+        nodeReportHandler.onMessage(

Review comment:
       @cku328 Thanks for the refactoring. I looked at the description of the test, and the what we are trying to validate. The test is meant to validate the logic to process a NodeReport correctly. It is not meant to validate whether a Node report is processed IF a heartbeat is got. Hence, I am OK with either of your patches - Using nodeReportHandler.onMessage or using nodeManager.processNodeManager. Maybe it is better to use the onMessage to keep it consistent with the other test you recently fixed. what do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org