DO NOT REPLY [Bug 9349] New: - WriterAppender ignoresThrowable handling reversed

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9349>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9349

WriterAppender ignoresThrowable handling reversed

           Summary: WriterAppender ignoresThrowable handling reversed
           Product: Log4j
           Version: 1.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Appender
        AssignedTo: log4j-dev@jakarta.apache.org
        ReportedBy: mthornton@eftia.com


Found while creating a new GUI Appender based on WriterAppender.java.  In the 
following source code from WriterAppender.java, it looks like throwable 
information will be outputted even if the Layout does not process error 
information.  I believe the line should be:  "if(!layout.ignoresThrowable())..."

    if(layout.ignoresThrowable()) {
      String[] s = event.getThrowableStrRep();-
      if (s != null) {
	int len = s.length;
	for(int i = 0; i < len; i++) {
	  this.qw.write(s[i]);
	  this.qw.write(Layout.LINE_SEP);
	}
      }

Haven't tested to confirm that it will be outputted because most layouts in the 
base product ignore throwable information.  But even if the information is not 
sent, there would be a performance hit on processing something that probably 
won't be outputted by the Layout.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>