You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/08 23:10:39 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41683: [SPARK-36680][SQL] Supports Dynamic Table Options for Spark SQL

dongjoon-hyun commented on code in PR #41683:
URL: https://github.com/apache/spark/pull/41683#discussion_r1287773297


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1118,6 +1122,38 @@ case class Range(
   }
 }
 
+@ExpressionDescription(
+  usage = "_FUNC_(identifier: String, options: Map) - " +
+    "Returns the data source relation with the given options.",
+  examples = """
+    Examples:
+      > SELECT * FROM _FUNC_('cat.db.table', map('foo','bar'));
+       1,a
+  """,
+  since = "3.5.0",

Review Comment:
   Shall we use `4.0.0`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org