You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by "mwunderl (via GitHub)" <gi...@apache.org> on 2023/10/11 20:38:01 UTC

[PR] [BUGFIX] utils.py - bool = bool [mxnet]

mwunderl opened a new pull request, #21223:
URL: https://github.com/apache/mxnet/pull/21223

   ## Description ##
   
   Importing mxnet with numpy 1.20+ results in 
   
   > AttributeError: module 'numpy' has no attribute 'bool'.
   `np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
       https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
   
   `np.bool` was a deprecated alias for the builtin `bool`, so replace `np.bool` with `bool`
   
   Tested locally with `mxnet-1.9.1-py3-none-manylinux2014_x86_64.whl` , numpy `1.24.4`, python `3.10.12`
   
   ## Checklist ##
   ### Essentials ###
   - [ x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x ] Changes are complete (i.e. I finished coding on this PR)
   - [x ] All changes have test coverage
   - [ x] Code is well-documented
   
   cf https://github.com/apache/mxnet/issues/21165
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BUGFIX] utils.py - bool = bool [mxnet]

Posted by "mxnet-bot (via GitHub)" <gi...@apache.org>.
mxnet-bot commented on PR #21223:
URL: https://github.com/apache/mxnet/pull/21223#issuecomment-1758498132

   Hey @mwunderl , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, miscellaneous, centos-gpu, windows-gpu, windows-cpu, edge, clang, sanity, unix-gpu, centos-cpu, unix-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org