You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/04/02 22:13:19 UTC

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
-----------------------------------------------------------

(Updated April 2, 2018, 10:13 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ed1c0abdf2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 3ed793ec48 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/6/

Changes: https://reviews.apache.org/r/66201/diff/5-6/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review200323
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Line 81 (original), 86 (patched)
<https://reviews.apache.org/r/66201/#comment281020>

    outdated comment


- Sergey Shelukhin


On April 2, 2018, 10:13 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> -----------------------------------------------------------
> 
> (Updated April 2, 2018, 10:13 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ed1c0abdf2 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 3ed793ec48 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
-----------------------------------------------------------

(Updated April 3, 2018, 7:48 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 08d26dc14e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 3ed793ec48 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/7/

Changes: https://reviews.apache.org/r/66201/diff/6-7/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review200326
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Lines 117 (patched)
<https://reviews.apache.org/r/66201/#comment281026>

    clean up whitespace.


- Jason Dere


On April 2, 2018, 10:13 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> -----------------------------------------------------------
> 
> (Updated April 2, 2018, 10:13 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ed1c0abdf2 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 3ed793ec48 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>