You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/30 19:59:00 UTC

[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

    [ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026959#comment-17026959 ] 

ASF subversion and git services commented on OFBIZ-10607:
---------------------------------------------------------

Commit b0aff701d05989214a7be932915bcc6c6489fa09 in ofbiz-framework's branch refs/heads/release17.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b0aff70 ]

Improved: ‘EntityOperator#getId()’ is not used in the framework
(OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

> ‘EntityOperator#getId()’ is not used in the framework
> -----------------------------------------------------
>
>                 Key: OFBIZ-10607
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10607
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Michael Brohl
>            Priority: Minor
>              Labels: backport-needed
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a test demonstrated its purpose and describing how to use it. Otherwise we should simply delete it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)