[GitHub] [ignite-extensions] nva commented on a diff in pull request #222: IGNITE-19921 Add thin client support for Spring Session.

["nva (via GitHub)" <gi...@apache.org>]

nva commented on code in PR #222:
URL: https://github.com/apache/ignite-extensions/pull/222#discussion_r1282604542


##########
modules/spring-session-ext/src/main/java/org/apache/ignite/spring/sessions/IgniteIndexedSessionRepository.java:
##########
@@ -384,38 +349,29 @@ private static TouchedExpiryPolicy createPolicy(Duration duration) {
      * A custom implementation of {@link Session} that uses a {@link MapSession} as the
      * basis for its mapping. It keeps track if changes have been made since last save.
      */
-    final class IgniteSession implements Session {
-
+    public class IgniteSession implements Session {

Review Comment:
   Yep, you are right that using a nested class for a value looks bad? but let's do it in https://issues.apache.org/jira/browse/IGNITE-18302, because it requires making this class static or move it to upper level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org