[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6091: Spark-3.3: Handle statistics file clean up from expireSnapshots action/procedure

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1131949519


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -276,12 +277,13 @@ private ExpireSnapshots.Result deleteFiles(Iterator<FileInfo> files) {
     }
 
     LOG.info("Deleted {} total files", summary.totalFilesCount());
-
-    return new BaseExpireSnapshotsActionResult(
-        summary.dataFilesCount(),
-        summary.positionDeleteFilesCount(),
-        summary.equalityDeleteFilesCount(),
-        summary.manifestsCount(),
-        summary.manifestListsCount());
+    return ImmutableResult.builder()

Review Comment:
   I am not familiar with this lib but won't the name conflict if we migrate more results to auto-generated beans as it does not take the parent class name into account?
   
   ```
   import org.apache.iceberg.actions.ImmutableResult;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org