You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/18 10:41:29 UTC
[GitHub] [tvm] masahi opened a new pull request #8068: [Relay, TOPI] Supporting dynamic slice on first few axes, keeping the rest static
masahi opened a new pull request #8068:
URL: https://github.com/apache/tvm/pull/8068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #8068: [Relay, TOPI] Support dynamic slicing on first few axes, keeping the rest static
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8068:
URL: https://github.com/apache/tvm/pull/8068#issuecomment-844490558
This looks good to me. Do we need to do anything to support this behavior in the standard strided slice op?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #8068: [Relay, TOPI] Supporting dynamic slice on first few axes, keeping the rest static
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #8068:
URL: https://github.com/apache/tvm/pull/8068#discussion_r634259431
##########
File path: tests/python/relay/dyn/test_dynamic_op_level4.py
##########
@@ -25,16 +25,19 @@
@tvm.testing.uses_gpu
def test_dynamic_strided_slice():
- def verify(dshape, begin, end, strides, output, slice_mode="end", test_ref=True, dtype="int32"):
Review comment:
`output` is not used in the test, so I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8068: [Relay, TOPI] Support dynamic slicing on first few axes, keeping the rest static
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8068:
URL: https://github.com/apache/tvm/pull/8068#issuecomment-844496100
No, I believe it is already supported, although the static version doesn't have a constraint that `len(begin) == len(end) == len(strides)`.
https://github.com/apache/tvm/blob/main/include/tvm/topi/transform.h#L651-L653
https://github.com/apache/tvm/blob/main/include/tvm/topi/transform.h#L672-L674
(No idea why CI is running another job, it already passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8068: [Relay, TOPI] Support dynamic slicing on first few axes, keeping the rest static
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8068:
URL: https://github.com/apache/tvm/pull/8068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8068: [Relay, TOPI] Support dynamic slicing on first few axes, keeping the rest static
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8068:
URL: https://github.com/apache/tvm/pull/8068#issuecomment-844626607
thanks @mbrookhart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org