[GitHub] [incubator-heron] simingweng commented on a change in pull request #3235: fix the issue that Heron ECO stream builder does not handle IStatefulWindowedBolt

[GitBox <gi...@apache.org>]

simingweng commented on a change in pull request #3235: fix the issue that Heron ECO stream builder does not handle IStatefulWindowedBolt
URL: https://github.com/apache/incubator-heron/pull/3235#discussion_r273730211
 
 

 ##########
 File path: tools/java/src/org/apache/bazel/cppcheck/CppCheck.java
 ##########
 @@ -113,7 +114,7 @@ private static void runChecker(List<String> command) throws IOException {
 
     if (cppcheck.exitValue() == 1) {
       LOG.warning("cppcheck detected bad cpp files.");
-      System.exit(1);
+      throw new RuntimeException("cppcheck detected bad cpp files.");
 
 Review comment:
   This is to fix a code styling issue that prevents the Heron docker image from being built.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services