You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/11 21:51:59 UTC

[GitHub] [tvm] driazati opened a new pull request, #11280: [profiler] Skip i386 skip condition

driazati opened a new pull request, #11280:
URL: https://github.com/apache/tvm/pull/11280

   See #10698 for some context, this test wasn't actually being skipped on i386
   
   cc @tkonolige
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tkonolige commented on pull request #11280: [profiler] Skip i386 skip condition

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #11280:
URL: https://github.com/apache/tvm/pull/11280#issuecomment-1124330316

   Oh yeah, I forgot to remove that skipif. The test should work on i386. Can you remove the skipif instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] driazati commented on pull request #11280: [profiler] Skip i386 skip condition

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #11280:
URL: https://github.com/apache/tvm/pull/11280#issuecomment-1124373939

   discussed a bit offline, the test does run on i386 but consistently [takes a long time](https://ci.tlcpack.ai/job/tvm/job/main/3246/testReport/ctypes.tests.python.unittest/test_runtime_profiling/) so we're keeping disabled until that gets debugged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] areusch merged pull request #11280: [profiler] Skip i386 skip condition

Posted by GitBox <gi...@apache.org>.
areusch merged PR #11280:
URL: https://github.com/apache/tvm/pull/11280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org