You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/12 20:52:08 UTC
[GitHub] [druid] jameskelleher opened a new pull request, #12432: Fix NOTES.txt tooltips when adding a LoadBalancer service
jameskelleher opened a new pull request, #12432:
URL: https://github.com/apache/druid/pull/12432
### Description
Fixes some errors in NOTES.txt when installing or upgrading with a `LoadBalancer` service.
1. Add the namespace arg in two commands where it was missing
2. Append `-router` to the end of the "fullnames". For example, with a basic install/upgrade, `kubectl get svc --namespace dev -w druid` fails but `kubectl get svc --namespace dev -w druid-router` works as intended.
3. Corrects the jsonpath search by changing `ip` to `hostname`.
Given a basic installation that does not change the configuration too much, and assuming that the service changed to a `LoadBalancer` is the router, the commands in this section of the notes now work as intended.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NOTES.txt tooltips when adding a LoadBalancer service (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12432:
URL: https://github.com/apache/druid/pull/12432#issuecomment-1885968525
This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jameskelleher commented on pull request #12432: Fix NOTES.txt tooltips when adding a LoadBalancer service
Posted by GitBox <gi...@apache.org>.
jameskelleher commented on PR #12432:
URL: https://github.com/apache/druid/pull/12432#issuecomment-1098141264
Hi! Not sure how to address that build failure – this is my first open source PR :) – based off the logs it looks like the exceptions don't have anything to do with my changes, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NOTES.txt tooltips when adding a LoadBalancer service (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12432:
URL: https://github.com/apache/druid/pull/12432#issuecomment-1853065838
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #12432: Fix NOTES.txt tooltips when adding a LoadBalancer service
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on PR #12432:
URL: https://github.com/apache/druid/pull/12432#issuecomment-1098149824
Yes, there are some flaky tests. I've re-started the failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix NOTES.txt tooltips when adding a LoadBalancer service (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12432: Fix NOTES.txt tooltips when adding a LoadBalancer service
URL: https://github.com/apache/druid/pull/12432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org