You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2013/01/28 19:51:12 UTC
[jira] [Commented] (PROTON-204) Handling of partial messages is
broken in java messenger
[ https://issues.apache.org/jira/browse/PROTON-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564521#comment-13564521 ]
Gordon Sim commented on PROTON-204:
-----------------------------------
This requires an additional method to be exposed on Delivery, equivalent to pn_delivery_partial(). Patch posted below in case there is any comment, but it is a trivial addition:
{noformat}
Index: proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Delivery.java
===================================================================
--- proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Delivery.java (revision 1439491)
+++ proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Delivery.java (working copy)
@@ -68,4 +68,6 @@
public Object getContext();
public boolean isUpdated();
+
+ public boolean isPartial();
}
Index: proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/DeliveryImpl.java
===================================================================
--- proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/DeliveryImpl.java (revision 1439491)
+++ proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/DeliveryImpl.java (working copy)
@@ -408,6 +408,11 @@
_complete = true;
}
+ public boolean isPartial()
+ {
+ return !_complete;
+ }
+
void setRemoteDeliveryState(DeliveryState remoteDeliveryState)
{
_remoteDeliveryState = remoteDeliveryState;
{noformat}
> Handling of partial messages is broken in java messenger
> --------------------------------------------------------
>
> Key: PROTON-204
> URL: https://issues.apache.org/jira/browse/PROTON-204
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.3
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.4
>
>
> I.e. where a read from the network reads part of a message but doesn't get all the data yet. This exhibits itself as a buffer underflow in MessengerImpl.get().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira