[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2769: ARTEMIS-2414 Sync before closing file in case data loss

[GitBox <gi...@apache.org>]

wy96f commented on a change in pull request #2769: ARTEMIS-2414 Sync before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2769#discussion_r308531572
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeServerMessageImpl.java
 ##########
 @@ -298,7 +298,7 @@ public int getBodyBufferSize() {
       } finally {
          if (closeFile) {
             try {
-               file.close();
+               file.close(false);
 
 Review comment:
   The getBodyBufferSize only retrieves the fileSize after opening file, and I assume this is only for reading. For this reason, I close it without flushing. I want to ask how you found files leaking? Are the leaking files large message ones?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services