You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2008/03/15 01:24:25 UTC
[jira] Created: (HADOOP-3023) [HOD] build file requires exact
python version
[HOD] build file requires exact python version
----------------------------------------------
Key: HADOOP-3023
URL: https://issues.apache.org/jira/browse/HADOOP-3023
Project: Hadoop Core
Issue Type: Improvement
Components: build
Reporter: Nigel Daley
Assignee: Vinod Kumar Vavilapalli
To run the HOD pyunit tests, the build file checks that an exact python version is present:
+ <condition property="python.versionmatched">
+ <!--- Currently check for only 2.5.1 -->
+ <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
+ </condition>
This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596003#action_12596003 ]
Hadoop QA commented on HADOOP-3023:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378954/HADOOP-3023
against trunk revision 655410.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2449/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2449/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2449/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2449/console
This message is automatically generated.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated HADOOP-3023:
--------------------------------------------
Status: Patch Available (was: Open)
Submitting again to verify if it is an OS issue or a transient failure at Hudson.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-3023:
--------------------------------
Status: Patch Available (was: Open)
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3023:
----------------------------------
Status: Open (was: Patch Available)
I'm canceling this patch, until the blocker is resolved.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596740#action_12596740 ]
Vinod Kumar Vavilapalli commented on HADOOP-3023:
-------------------------------------------------
Even this Hudson run, RunHodCleanupTests took 300 secs to finish, instead of returning immediately as expected.
{quote}
[exec] [exec] Running RunHodCleanupTests
[exec] [exec] ...
[exec] [exec] ----------------------------------------------------------------------
[exec] [exec] Ran 3 tests in 300.059s
[exec] [exec]
[exec] [exec] OK
[exec] [exec] Finished RunHodCleanupTests. TestSuite Result : 0
{quote}
Created a separate JIRA to address this issue - HADOOP-3389, which blocks this issue.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594568#action_12594568 ]
Vinod Kumar Vavilapalli commented on HADOOP-3023:
-------------------------------------------------
The failed core test org.apache.hadoop.dfs.TestBalancer.testBalancer0 is not related to this fix.
@Nigel: The failed HOD contrib test RunHodCleanupTests runs fine on my local system(linux). It might be that the test fails on the Hudson's solaris box, can we verify this? I thought of resubmitting it to Hudson, but held back thinking it would unnecessarily block other patches. If you can run all the tests again (run ant test in contrib/hod directory) or only this particular test (run "python src/contrib/hod/testing/testHodCleanup.py"), on the Hudson machine and commit the results here, that would help. If you want, I can run it myself, but then I need access to this or any other solaris box.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated HADOOP-3023:
--------------------------------------------
Status: Open (was: Patch Available)
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated HADOOP-3023:
--------------------------------------------
Attachment: HADOOP-3023
Attaching a patch. This removes the python version check from ant build.xml. This is moved to testing/main.py which is the entry point for running test cases.
ant test now runs the tests when it finds python of version 2.5.1 or greater specified through -Dpython.home. If it finds a lesser version, it fails with return code 1, and with proper message. In case of a particular test-case failing, testing/main.py returns an error code 2. It returns a 0 when all test-cases run successfully.
Also refactored code in testing/main.py
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3023) [HOD] build file requires exact
python version
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594309#action_12594309 ]
Hadoop QA commented on HADOOP-3023:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378954/HADOOP-3023
against trunk revision 653264.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2397/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2397/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2397/console
This message is automatically generated.
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.