You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/19 13:27:05 UTC
[GitHub] [flink-kubernetes-operator] Aitozi opened a new pull request #86: [FLINK-26737] Add CRD management in development doc
Aitozi opened a new pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86
Add CRD management in development doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86#discussion_r830810495
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
Review comment:
Should be: **Generating and Upgrading the CRD**
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by the [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
+When installing flink-operator for the first time, the CRD will apply to the kubernetes cluster automatically. But it will not be removed or upgraded when re-install the flink-operator, as described in the relevant helm [documentation](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
Review comment:
Should be:
the CRD will **be applied** to the kubernetes
upgraded when **re-installing** the flink-operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a change in pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
mbalassi commented on a change in pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86#discussion_r830499050
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
+When installing flink-operator first time, the CRD will apply to the kubernetes cluster automatically. But it will not be removed or upgraded when re-install the flink-operator, referring to helm [doc](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
Review comment:
Instead of:
the flink-operator, referring to helm doc
Please use:
the flink-operator as described in the relevant helm documentation
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
Review comment:
Please update:
... generated by _the_ Fabric8 ...
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
+When installing flink-operator first time, the CRD will apply to the kubernetes cluster automatically. But it will not be removed or upgraded when re-install the flink-operator, referring to helm [doc](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
Review comment:
Please update:
When installing flink-operator _for the_ first time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
Aitozi commented on a change in pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86#discussion_r830554232
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
Review comment:
fixed
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
+When installing flink-operator first time, the CRD will apply to the kubernetes cluster automatically. But it will not be removed or upgraded when re-install the flink-operator, referring to helm [doc](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86#issuecomment-1073159482
@mbalassi Thanks for your comments, I have fixed it. Please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
Aitozi commented on a change in pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86#discussion_r830823733
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
+
+By default, the CRD is generated by the [Fabric8 CRDGenerator](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md), when building from source.
+When installing flink-operator for the first time, the CRD will apply to the kubernetes cluster automatically. But it will not be removed or upgraded when re-install the flink-operator, as described in the relevant helm [documentation](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
Review comment:
Fixed
##########
File path: docs/content/docs/development/guide.md
##########
@@ -93,6 +93,22 @@ rest.port: 8081
rest.address: localhost
```
+### Uninstalling the operator locally
+```bash
+helm uninstall flink-operator
+```
+
+### CRD Generating and Upgrading
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #86: [FLINK-26737] Add CRD management in development doc
Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #86:
URL: https://github.com/apache/flink-kubernetes-operator/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org