You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juha Syrjälä (JIRA)" <ji...@apache.org> on 2012/08/03 14:15:02 UTC
[jira] [Created] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Juha Syrjälä created WICKET-4695:
------------------------------------
Summary: Javascript error when closing a ModalWindow with IE 8
Key: WICKET-4695
URL: https://issues.apache.org/jira/browse/WICKET-4695
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5.5
Environment: Internet Explorer 8
Reporter: Juha Syrjälä
Priority: Minor
Closing a ModalWindow in IE 8 may cause following javascript error to console:
'win.current' is null or not an object
This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
+ "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
modal.js, Window.close, line 258
if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Juha Syrjälä (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428039#comment-13428039 ]
Juha Syrjälä commented on WICKET-4695:
--------------------------------------
By the way, instructions to provide a patch are not correct in http://wicket.apache.org/contribute/patch.html
git diff should have parameter --cached. Adding changes to index makes them disappear from git diff.
git add any_files_you_created_modified_or_deleted
git diff --cached > /tmp/fix-WICKET-NNNN.patch
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
> Attachments: fix-WICKET-4695.patch
>
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Juha Syrjälä (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juha Syrjälä updated WICKET-4695:
---------------------------------
Attachment: fix-WICKET-4695.patch
Patch that contains changed detailed in issue description.
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
> Attachments: fix-WICKET-4695.patch
>
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Juha Syrjälä (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428030#comment-13428030 ]
Juha Syrjälä commented on WICKET-4695:
--------------------------------------
It doesn't happen in http://www.wicket-library.com/wicket-examples/ajax/modal-window.
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428025#comment-13428025 ]
Martin Grigorov commented on WICKET-4695:
-----------------------------------------
Can you reproduce the problem at http://www.wicket-library.com/wicket-examples/ajax/modal-window ?
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4695.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.8
6.0.0
Assignee: Martin Grigorov
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
> Fix For: 6.0.0, 1.5.8
>
> Attachments: fix-WICKET-4695-for-wicket-1.5.x.patch, fix-WICKET-4695.patch
>
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Juha Syrjälä (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428027#comment-13428027 ]
Juha Syrjälä commented on WICKET-4695:
--------------------------------------
I looked at sources in master branch in git, and it seems that the same problem is present in also in the latest version.
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4695) Javascript error when closing a
ModalWindow with IE 8
Posted by "Juha Syrjälä (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juha Syrjälä updated WICKET-4695:
---------------------------------
Attachment: fix-WICKET-4695-for-wicket-1.5.x.patch
Add also patch for wicket-1.5.x branch.
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
> Attachments: fix-WICKET-4695-for-wicket-1.5.x.patch, fix-WICKET-4695.patch
>
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira