You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "coderfender (via GitHub)" <gi...@apache.org> on 2026/02/21 19:33:32 UTC

Re: [PR] feat: Cast numeric (non int) to timestamp [datafusion-comet]

coderfender commented on code in PR #3559:
URL: https://github.com/apache/datafusion-comet/pull/3559#discussion_r2836509473


##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -1276,4 +1276,40 @@ abstract class CometTestBase
     !usingLegacyNativeCometScan(conf) &&
     CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.get(conf)
   }
+
+  /**
+   * Uses except (difference) to find differences without using collect()
+   * Checks cometDF and sparkDF including schemas
+   */
+  protected def assertDataFrameEquals(

Review Comment:
   In my recent [PR](https://github.com/apache/datafusion-comet/pull/3541) , I had to cast back the generated I had to resort to this route because we have no native comet support from Timestamp -> Float causing operator / native comet check assertion failures



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org