You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 09:58:33 UTC
[GitHub] [doris] freemandealer opened a new issue, #15246: [Enhancement] allow table in url when do two-phase commit
freemandealer opened a new issue, #15246:
URL: https://github.com/apache/doris/issues/15246
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
### Description
when doing two-phase load, user need to do following two steps:
1) precommit
curl --location-trusted -u user:passwd -H "two_phase_commit:true" -T test.txt http://fe_host:http_port/api/{db}/{table}/_stream_load
2) actual commit
curl -X PUT --location-trusted -u user:passwd -H "txn_id:18036" -H "txn_operation:commit" http://fe_host:http_port/api/{db}/_stream_load_2pc
the url in step 2) has two difference against step 1):
1. _stream_load -> _stream_load_2pc, which is obvious
2. {table} is omitted, which is not very obvious
Is is reasonable to remove {table} because Txn id is provided so {table} is no longer needed. But user can be confused if they failed to omit it -- usually one may just copy&paste the url.
### Solution
let us make it works even if user provide us with (unnecessary) table info in url. i.e., `curl -X PUT --location-trusted -u user:passwd -H "txn_id:18036" -H "txn_operation:commit" http://fe_host:http_port/api/{db}/{table}/_stream_load_2pc` can still works!
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring closed issue #15246: [Enhancement] allow table in url when do two-phase commit
Posted by GitBox <gi...@apache.org>.
dataroaring closed issue #15246: [Enhancement] allow table in url when do two-phase commit
URL: https://github.com/apache/doris/issues/15246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org