You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2017/06/19 11:07:23 UTC

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1348

    ARTEMIS-1237 - Hard coded timeout on Journal file open

    Make timeout configurable
    
    https://issues.apache.org/jira/browse/ARTEMIS-1237

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis open_timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1348
    
----
commit 5baa0559b69b3f9832c416904b31d48692a01e36
Author: Andy Taylor <an...@gmail.com>
Date:   2017-06-19T11:04:21Z

    ARTEMIS-1237 - Hard coded timeout on Journal file open
    
    Make timeout configurable
    
    https://issues.apache.org/jira/browse/ARTEMIS-1237

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1348


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1348
  
    @andytaylor we can't make a change on 1.x only... it needs to be on master...
    
    I tried cherry-pick but had tons of conflicts.. can you do it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1348
  
    @andytaylor  where is master's PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1348#discussion_r123010910
  
    --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
    @@ -688,6 +688,15 @@
                 </xsd:annotation>
              </xsd:element>
     
    +         <xsd:element name="journal-file-open-timeout" type="xsd:int" maxOccurs="1" minOccurs="0">
    +            <xsd:annotation>
    +               <xsd:documentation>
    +                  the maximum number of write requests that can be in the AIO queue at any one time. Default is 500 for
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1348#discussion_r123011945
  
    --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
    @@ -688,6 +688,15 @@
                 </xsd:annotation>
              </xsd:element>
     
    +         <xsd:element name="journal-file-open-timeout" type="xsd:int" maxOccurs="1" minOccurs="0">
    +            <xsd:annotation>
    +               <xsd:documentation>
    +                  the maximum number of write requests that can be in the AIO queue at any one time. Default is 500 for
    --- End diff --
    
    Thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1348
  
    can you close this please? merged with a rebase! apache bot won't close 1.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1348#discussion_r122838823
  
    --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
    @@ -688,6 +688,15 @@
                 </xsd:annotation>
              </xsd:element>
     
    +         <xsd:element name="journal-file-open-timeout" type="xsd:int" maxOccurs="1" minOccurs="0">
    +            <xsd:annotation>
    +               <xsd:documentation>
    +                  the maximum number of write requests that can be in the AIO queue at any one time. Default is 500 for
    --- End diff --
    
    documentation doesn't seem to match element. Assume it should read more like.
    
    > the length of time to wait when opening a new Journal file before timing out and failing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1348: ARTEMIS-1237 - Hard coded timeout on Journal f...

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1348
  
    https://github.com/apache/activemq-artemis/pull/1359


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---