[GitHub] gbloisi commented on a change in pull request #22936: [SPARK-19799] Support WITH clause (CTE) in subqueries

[GitBox <gi...@apache.org>]

gbloisi commented on a change in pull request #22936: [SPARK-19799] Support WITH clause (CTE) in subqueries
URL: https://github.com/apache/spark/pull/22936#discussion_r255345243
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
 ##########
 @@ -535,7 +535,19 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
         |q2 as (select * from testData where key = '4')
         |select * from q1 union all select * from q2""".stripMargin),
       Row(5, "5") :: Row(4, "4") :: Nil)
+  }
 
+  test("SPARK-19799: Support WITH clause in subqueries") {
 
 Review comment:
   I need to find some spare time for that, but I'll surely do sooner or later. I assumed that most of the correctness comes from https://github.com/apache/spark/pull/15146 but surely there may be interactions that goes beyond that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org