You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "luigidemasi (via GitHub)" <gi...@apache.org> on 2023/12/01 19:16:45 UTC
[PR] CAMEL-20174: camel-ssh: Provide support to configure algorithms [camel]
luigidemasi opened a new pull request, #12294:
URL: https://github.com/apache/camel/pull/12294
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20174: camel-ssh: Provide support to configure algorithms [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12294:
URL: https://github.com/apache/camel/pull/12294#issuecomment-1836643610
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20174: camel-ssh: Provide support to configure algorithms [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #12294:
URL: https://github.com/apache/camel/pull/12294#discussion_r1412538994
##########
components/camel-ssh/src/main/java/org/apache/camel/component/ssh/SshConfiguration.java:
##########
@@ -62,6 +64,18 @@ public class SshConfiguration implements Cloneable {
private String shellPrompt;
@UriParam(label = "advanced", defaultValue = "100")
private long sleepForShellPrompt;
+ @UriParam(label = "security")
+ private String kex;
+ @UriParam(label = "security")
+ private String ciphers;
+ @UriParam(label = "security")
+ private String macs;
+ @UriParam(label = "security")
+ private String signatures;
+ @UriParam(label = "advanced")
+ private String compressions;
+ @UriParam(label = "advanced,producer,consumer")
Review Comment:
producer and consumer is default, (ie. common), so this can just be "advanced"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20174: camel-ssh: Provide support to configure algorithms [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #12294:
URL: https://github.com/apache/camel/pull/12294#discussion_r1412756653
##########
components/camel-ssh/src/main/java/org/apache/camel/component/ssh/SshConfiguration.java:
##########
@@ -62,6 +64,18 @@ public class SshConfiguration implements Cloneable {
private String shellPrompt;
@UriParam(label = "advanced", defaultValue = "100")
private long sleepForShellPrompt;
+ @UriParam(label = "security")
+ private String kex;
+ @UriParam(label = "security")
+ private String ciphers;
+ @UriParam(label = "security")
+ private String macs;
+ @UriParam(label = "security")
+ private String signatures;
+ @UriParam(label = "advanced")
+ private String compressions;
+ @UriParam(label = "advanced")
Review Comment:
If it makes sense it can be autowired = true, so camel will automatic inject an existing instance if present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20174: camel-ssh: Provide support to configure algorithms [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #12294:
URL: https://github.com/apache/camel/pull/12294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org