[GitHub] oleg-zinovev commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters

[GitBox <gi...@apache.org>]

oleg-zinovev commented on a change in pull request #1450: DRILL-6717: lower and upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213732578
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
 ##########
 @@ -1441,11 +1442,12 @@ public void testUpper() throws Exception {
             "upper('AbC aBc') as col_space,\n" +
             "upper('123ABC$!abc123.') as col_special,\n" +
             "upper('') as col_empty,\n" +
-            "upper(cast(null as varchar(10))) as col_null\n" +
+            "upper(cast(null as varchar(10))) as col_null,\n" +
+            "upper('привет, мир!') as col_national\n" +
 
 Review comment:
   @Ben-Zvi 
   The test works, but I'm confused by the reason:
   `ß` - 2 byte character, converting it to the upper case returns 2 single-byte `S` characters. Are there any other examples of such symbols?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services