You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kevinjmh <gi...@git.apache.org> on 2017/12/10 10:54:05 UTC

[GitHub] carbondata pull request #1636: [CARBONDATA-1801] Remove unnecessary mdk comp...

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/1636

    [CARBONDATA-1801] Remove unnecessary mdk computation code

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [No] Any interfaces changed?
     
     - [No ] Any backward compatibility impacted?
     
     - [ No] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1636
    
----
commit e4e14d069590d116685b02aceaf3c2839ac3e66e
Author: Manhua <ke...@qq.com>
Date:   2017-12-10T10:46:53Z

    [CARBONDATA-1801] Remove unnecessary mdk computation code

----


---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2273/



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1928/



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by chenliang613 <gi...@git.apache.org>.

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    @kevinjmh there are some findbugs issues, please check.


---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by chenliang613 <gi...@git.apache.org>.

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    @kevinjmh  this pr , looks you introduced many other commit record? 
    may need to rework :) 


---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1947/



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    Can one of the admins verify this patch?


---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by chenliang613 <gi...@git.apache.org>.

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    @kevinjmh  suggest you first close this pr, then raise a new one.
    



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2270/



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/719/



---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by chenliang613 <gi...@git.apache.org>.

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    retest this please


---

[GitHub] carbondata issue #1636: [CARBONDATA-1801] Remove unnecessary mdk computation...

Posted by chenliang613 <gi...@git.apache.org>.

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1636
  
    add to whitelist


---