You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2015/11/30 21:01:32 UTC
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
GitHub user pietermartin opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/161
use the GraphProvider to convert hardcoded ids
The hardcoded integer ids fail on providers that do not have integer ids.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pietermartin/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit 3a78fdb6300a47936d59c4897b19f5aa3f296e9b
Author: pieter <pi...@gmail.com>
Date: 2015-11-30T20:00:15Z
use the GraphProvider to convert hardcoded ids
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/161#issuecomment-160744894
@pietermartin -- sorry to be picky, but can you make it be:
```
g.V(convertToVertexId("marko")).blah().blah()
```
instead of the direct reference to the `graphProvider` ? Or, if you want, upon merge, I can convert accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/161#issuecomment-160753000
@okram Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/161#issuecomment-160759843
I ran `mvn clean install` and all passed. This is a trivial fix so I'm just going to CTR merge it.
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:32.775s
[INFO] Finished at: Mon Nov 30 13:55:37 MST 2015
[INFO] Final Memory: 112M/788M
[INFO] ------------------------------------------------------------------------
~/software/tinkerpop/tinkerpop3$
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: use the GraphProvider to convert...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/161#issuecomment-160743144
This references TINKERPOP3-1001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---