You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/10 06:41:55 UTC

[GitHub] [apisix-website] iamayushdas opened a new pull request #336: feat: darkmode added to download-dropdown

iamayushdas opened a new pull request #336:
URL: https://github.com/apache/apisix-website/pull/336


   Fixes: #329 
   
   Changes:
   
   Added darkmode for download button -> dropdown menu
   
   Screenshots of the change:
   
   Earlier:
   ![Screenshot from 2021-05-10 12-10-53](https://user-images.githubusercontent.com/40708551/117616483-d1e44a00-b188-11eb-9089-932e21958ebb.png)
   
   Now:
   ![Screenshot from 2021-05-10 12-09-28](https://user-images.githubusercontent.com/40708551/117616395-b2e5b800-b188-11eb-96a6-432a8ebe48fa.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* ready!
   
   Built with commit 3ae527cf5d7d2158c8ece999bdff7056f1bc9efd
   
   https://deploy-preview-336--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* ready!
   
   Built with commit 81cb7daf9ec27986a834a57139d463cc0535ba5a
   
   https://deploy-preview-336--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu merged pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #336:
URL: https://github.com/apache/apisix-website/pull/336


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836275111


   ![image](https://user-images.githubusercontent.com/34589752/117619261-0c27fa00-b13d-11eb-90ee-44aaa7208332.png)
   
   Currently the color change at hover is too small for user to make sure where is s/he


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#discussion_r629791259



##########
File path: website/src/css/customTheme.css
##########
@@ -644,4 +656,4 @@ a:hover {
 
 .help-page .card p {
   color: var(--color-help-subtitle);
-}
+}

Review comment:
       ```suggestion
   }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* processing.
   
   Building with commit 81cb7daf9ec27986a834a57139d463cc0535ba5a
   
   https://app.netlify.com/sites/apisix/deploys/6098e4a236ff770008e5957f


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* processing.
   
   Building with commit eb426820a1eb8b119febb90e22588483b7293dfc
   
   https://app.netlify.com/sites/apisix/deploys/6098d5a8edc1db0008b4b9ea


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* processing.
   
   Building with commit 3ae527cf5d7d2158c8ece999bdff7056f1bc9efd
   
   https://app.netlify.com/sites/apisix/deploys/6099e202e79c50000828ddb2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836250687


   Deploy preview for *apisix* ready!
   
   Built with commit eb426820a1eb8b119febb90e22588483b7293dfc
   
   https://deploy-preview-336--apisix.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-837756916


   @Yiyiyimu new line has been added, have a look now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#discussion_r629577009



##########
File path: website/src/css/customTheme.css
##########
@@ -644,4 +656,4 @@ a:hover {
 
 .help-page .card p {
   color: var(--color-help-subtitle);
-}
+}

Review comment:
       missing a newline here. Maybe you could make your IDE do the check




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836313586


   > ![image](https://user-images.githubusercontent.com/34589752/117619261-0c27fa00-b13d-11eb-90ee-44aaa7208332.png)
   > 
   > Currently the color change at hover is too small for user to make sure where is s/he
   
   is it fine now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836276966


   > ![image](https://user-images.githubusercontent.com/34589752/117619261-0c27fa00-b13d-11eb-90ee-44aaa7208332.png)
   > 
   > Currently the color change at hover is too small for user to make sure where is s/he
   
   OKAY ,thanks for reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on pull request #336: feat: darkmode added to download-dropdown

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #336:
URL: https://github.com/apache/apisix-website/pull/336#issuecomment-836258238


   > The deployed version looks good to me.
   > @iamayushdas Thanks.
   
   your welcome :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org