You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2019/09/30 06:22:42 UTC

[camel-k-runtime] 02/02: Fix some findings

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-k-runtime.git

commit 02574168bf2c329ce885d6c327dfc65b10808752
Author: lburgazzoli <lb...@gmail.com>
AuthorDate: Sat Sep 28 13:51:37 2019 +0200

    Fix some findings
---
 .../.gitignore                                     |  1 -
 .../processors/GenerateYamlSupportClassesTest.java | 47 ++++++++++++----------
 2 files changed, 26 insertions(+), 22 deletions(-)

diff --git a/examples/camel-k-runtime-example-quarkus-knative/.gitignore b/examples/camel-k-runtime-example-quarkus-knative/.gitignore
deleted file mode 100644
index 8b13789..0000000
--- a/examples/camel-k-runtime-example-quarkus-knative/.gitignore
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/tooling/camel-k-maven-plugin/src/test/java/org/apache/camel/k/tooling/maven/processors/GenerateYamlSupportClassesTest.java b/tooling/camel-k-maven-plugin/src/test/java/org/apache/camel/k/tooling/maven/processors/GenerateYamlSupportClassesTest.java
index 0689d1d..27784f1 100644
--- a/tooling/camel-k-maven-plugin/src/test/java/org/apache/camel/k/tooling/maven/processors/GenerateYamlSupportClassesTest.java
+++ b/tooling/camel-k-maven-plugin/src/test/java/org/apache/camel/k/tooling/maven/processors/GenerateYamlSupportClassesTest.java
@@ -16,36 +16,41 @@
  */
 package org.apache.camel.k.tooling.maven.processors;
 
-import java.io.IOException;
-
 import com.squareup.javapoet.JavaFile;
+import com.squareup.javapoet.TypeSpec;
 import org.apache.camel.k.tooling.maven.GenerateYamlSupportClasses;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 public class GenerateYamlSupportClassesTest {
-    @Disabled
     @Test
-    public void testGenerateHasDataFormat() throws IOException {
-        JavaFile.builder("org.apache.camel.k.loader.yaml.parser", new GenerateYamlSupportClasses().generateHasDataFormat())
-            .indent("    ")
-            .build()
-            .writeTo(System.out);
+    public void testGenerateHasDataFormat() {
+        final TypeSpec spec = new GenerateYamlSupportClasses().generateHasDataFormat();
+        final JavaFile file = JavaFile.builder("org.apache.camel.k.loader.yaml.parser", spec).build();
+
+        assertThat(file.packageName).isEqualTo("org.apache.camel.k.loader.yaml.parser");
+        assertThat(spec.name).isEqualTo("HasDataFormat");
+        assertThat(spec.methodSpecs).isNotEmpty();
     }
-    @Disabled
+
     @Test
-    public void testGenerateHasExpression() throws IOException {
-        JavaFile.builder("org.apache.camel.k.loader.yaml.parser", new GenerateYamlSupportClasses().generateHasExpression())
-            .indent("    ")
-            .build()
-            .writeTo(System.out);
+    public void testGenerateHasExpression() {
+        final TypeSpec spec = new GenerateYamlSupportClasses().generateHasExpression();
+        final JavaFile file = JavaFile.builder("org.apache.camel.k.loader.yaml.parser", spec).build();
+
+        assertThat(file.packageName).isEqualTo("org.apache.camel.k.loader.yaml.parser");
+        assertThat(spec.name).isEqualTo("HasExpression");
+        assertThat(spec.methodSpecs).isNotEmpty();
     }
-    @Disabled
+
     @Test
-    public void testGenerateJacksonModule() throws IOException {
-        JavaFile.builder("org.apache.camel.k.loader.yaml.parser", new GenerateYamlSupportClasses().generateJacksonModule())
-            .indent("    ")
-            .build()
-            .writeTo(System.out);
+    public void testGenerateJacksonModule() {
+        final TypeSpec spec = new GenerateYamlSupportClasses().generateJacksonModule();
+        final JavaFile file = JavaFile.builder("org.apache.camel.k.loader.yaml", spec).build();
+
+        assertThat(file.packageName).isEqualTo("org.apache.camel.k.loader.yaml");
+        assertThat(spec.name).isEqualTo("YamlModule");
+        assertThat(spec.methodSpecs).isNotEmpty();
     }
 }