[GitHub] [lucene-solr] gerlowskija commented on pull request #1728: SOLR-14596: equals/hashCode for common SolrRequest classes

[GitBox <gi...@apache.org>]

gerlowskija commented on pull request #1728:
URL: https://github.com/apache/lucene-solr/pull/1728#issuecomment-674422652


   > Were these autogenerated? By which IDE?
   
   They weren't, no.  But in many cases they could be.  I skipped autogeneration because in a lot of cases I needed to dig into the instance variables in question to understand (1) whether they were relevant for equality, and (2) whether the instance variable types had adequate hashCode/equals methods themselves (e.g. SolrResponse.equals relies on ResponseParser.equals which didn't exist).
   
   But I've got nothing against autogenerated methods if they're double-checked, and I might go that route in other parts of SolrJ. 🤷 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org