You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by aditya1702 <gi...@git.apache.org> on 2016/11/19 21:37:18 UTC
[GitHub] spark pull request #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`No...
GitHub user aditya1702 opened a pull request:
https://github.com/apache/spark/pull/15940
[SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that` across Pyth\u2026
## What changes were proposed in this pull request?
It seems that just like in Scala/Java there is inconsistency in the Python API too at some places,
Note:
NOTE:
Note that
'''Note:'''
@note
This PR proposes to fix those to @note to be consistent.
## How was this patch tested?
This was tested by searching in the editor for versions of "NOTE" in the python APIs and then fixing them to become consistence.
This PR is a sub-extension of #15889
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aditya1702/spark aditya1702-python-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15940
----
commit 688a6cca8695fd3d74547b72ea02d1dc7a0df87d
Author: aditya1702 <ad...@gmail.com>
Date: 2016-11-19T21:26:34Z
[SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that` across Python API documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by aditya1702 <gi...@git.apache.org>.
Github user aditya1702 commented on the issue:
https://github.com/apache/spark/pull/15940
@HyukjinKwon @rxin Yes I think I got confused as pointed out by Hyukjin above \U0001f605 . @HyukjinKwon you can take this one over and cc me. I will work on another issue. Sorry for the troubles
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by aditya1702 <gi...@git.apache.org>.
Github user aditya1702 commented on the issue:
https://github.com/apache/spark/pull/15940
@HyukjinKwon Could you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`No...
Posted by aditya1702 <gi...@git.apache.org>.
Github user aditya1702 closed the pull request at:
https://github.com/apache/spark/pull/15940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15940
Ah, @aditya1702, I assume, from the title, you meant to do this for Python documentation. Actually, the PR you pointed out deals with all of Scala/Java documentation if I haven\u2019t missed some. Maybe, `.. note:` in Python codes should be handled for Python API documentation including some images from manually built API documentation in the PR. If you are not sure of what to fix, I can take over this and cc you in the PR. I guess you could close this PR meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15940
Yes, you should check if they are exposed in the API documentation. I intentionally updated only those ones before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15940
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15940
I don't think any of these actually matter, because these functions are not public documentations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org