[GitHub] [cloudstack] GabrielBrascher commented on issue #3839: FEATURE-3823: kvm agent hooks

[GitBox <gi...@apache.org>]

GabrielBrascher commented on issue #3839: FEATURE-3823: kvm agent hooks
URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-590332057
 
 
   @bwsw thanks for the PR.
   
   > sorry about being slightly nervous about that. This is my fault.
   
   Sorry if you had problems to align the proposal. In a complex project such as CloudStack with all stacks involved (management and agents, connecting storage, network, hypervisors, etc) with multiple user cases, it is common to have a few misunderstandings. I am sure that all reviewers had good intention.
   
   With that said, personally I see value on adding this to ACS codebase and the proposal looks very interesting. I had no time yet to review the code but it is good to see that it has been manually tested and it works as expected.
   
   Going in the same direction as @DaanHoogland, it would be great to add a few examples describing how one can configure agent hooks. Is there any documentation regarding how a system admin can configure agent hooks that could be added to the [CloudStack documentation](https://github.com/apache/cloudstack-documentation)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services