You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ritegarg (via GitHub)" <gi...@apache.org> on 2026/06/11 22:45:18 UTC

[PR] PHOENIX-7566 Keep SYSTEM.HA_GROUP ZK and HDFS URLs paired in periodic ZK sync [phoenix]

ritegarg opened a new pull request, #2521:
URL: https://github.com/apache/phoenix/pull/2521

   
   
   The periodic ZK->SYSTEM.HA_GROUP sync (HAGroupStoreClient#syncZKToSystemTable) rewrote the slot-indexed ZK_URL_n / CLUSTER_URL_n / CLUSTER_ROLE_n columns in a local-first order but never wrote HDFS_URL_1 / HDFS_URL_2. On the cluster whose ZK URL did not already occupy slot 1, this flipped the ZK/cluster/role columns while leaving the HDFS columns in place, so ZK_URL_n no longer referred to the same cluster as HDFS_URL_n. The read path (getSystemTableHAGroupRecord) resolves a cluster's HDFS URL by matching its ZK URL slot, so the swap propagated a wrong local/peer HDFS URL into the ZK record and replication wrote to the wrong IN directory.
   
   Fix: updateSystemTableHAGroupRecordSilently now writes all slot columns (including HDFS_URL_1/2) in a deterministic canonical order keyed on the formatted ZK URL (mirroring ClusterRoleRecord's url1/url2 canonicalization). Because the order does not depend on which cluster is local, both clusters of a pair persist identical rows and ZK_URL_n always stays paired with HDFS_URL_n; the sync self-heals an already-desynced row on its next cycle.
   
   The periodic-sync IT now seeds the corrupted (mispaired) shape and asserts the row is re-paired into canonical slot order.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://phoenix.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] PHOENIX-XXXX Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes, and prefix it with the JIRA id, e.g. 'PHOENIX-XXXX Your PR title ...'.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
   
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Phoenix versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] PHOENIX-7566 Fix periodic ZK→SYSTEM.HA_GROUP sync: pair ZK/HDFS URLs and avoid redundant rewrites [phoenix]

Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana merged PR #2521:
URL: https://github.com/apache/phoenix/pull/2521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org