[GitHub] spark pull request: [Spark-14300][Docs][MLLIB]Scala MLlib examples...

[keypointt <gi...@git.apache.org>]

Github user keypointt commented on the pull request:

    https://github.com/apache/spark/pull/12195#issuecomment-206102900
  
    #### Unsure code duplications (need doube check)
    
    - AbstractParams.scala - cannot delete this one, not duplicate, its usage found in many examples
    
    - BinaryClassification.scala - @pending: not sure, duplicate of mllib/BinaryClassificationMetricsExample ???
        
    - CosineSimilarity.scala - @pending: personally I prefer to keep it as a demo
        
    - MovieLensALS.scala - @pending: duplicate of LocalALS.scala, but I prefer to delete LocalALS.scala but keep MovieLensALS.scala, since MovieLensALS better commented
       
    - MultivariateSummarizer.scala - @pending: usage not found, but better keep it for possible later demo
        
    - RandomRDDGeneration.scala - @pending: usage not found, but better keep it for possible later demo
        
    - SampledRDDs.scala - @pending: usage not found, but better keep it for possible later demo
    
    hi @yinxusen, for above @pending ones, I'm not sure we should delete them or not? There are no usage found for them, but personally I find they are still useful examples


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org