You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/10 14:31:18 UTC

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit

tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223#issuecomment-584149716
 
 
   Hi @beijing-penguin It is a great PR, which i can see your understanding of Visitor mechanism.
   Congrats for your grow-up!
   
   Other than that, the rule name of `onObjectClause_` should be renamed a `onObjectClause` in its g4 file. You could fix it in another PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services