You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/10 12:44:49 UTC

[GitHub] [netbeans] zeleznypa opened a new issue, #4611: PHP code format - no new line after last method

zeleznypa opened a new issue, #4611:
URL: https://github.com/apache/netbeans/issues/4611

   ### Description
   
   To be able to setup the PSR-12 compatible auto-format, I have to add one empty line „after function“
   
   <img width="471" alt="Snímek obrazovky 2022-09-10 v 14 28 48" src="https://user-images.githubusercontent.com/1191472/189483822-f699f171-2ef9-4ae2-91ba-65a9770e30a4.png">
   
   But the PSR don't want to have blank line before the class closing curly bracket.
   
   ### Use case/motivation
   
   I want to have code auto-formatted in PSR-12 compatible way.
   
   Current result:
   ```php
   class Foo
   {
       public function bar() {
           // some code
       }
   
       public function baz() {
           // some code
       }
   
   }
   ```
   
   Expected result:
   ```php
   class Foo
   {
       public function bar() {
           // some code
       }
   
       public function baz() {
           // some code
       }
   }
   ```
   
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a pull request?
   
   No
   
   ### Code of Conduct
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik closed issue #4611: PHP code format - no new line after last method

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik closed issue #4611: PHP code format - no new line after last method
URL: https://github.com/apache/netbeans/issues/4611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] zeleznypa commented on issue #4611: PHP code format - no new line after last method

Posted by "zeleznypa (via GitHub)" <gi...@apache.org>.
zeleznypa commented on issue #4611:
URL: https://github.com/apache/netbeans/issues/4611#issuecomment-1490006920

   @junichi11 Thanks much to you also :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on issue #4611: PHP code format - no new line after last method

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on issue #4611:
URL: https://github.com/apache/netbeans/issues/4611#issuecomment-1490103478

   You're welcome :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] KacerCZ commented on issue #4611: PHP code format - no new line after last method

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on issue #4611:
URL: https://github.com/apache/netbeans/issues/4611#issuecomment-1383106966

   It seems that setting blank lines "Before Class End" is only able to add more blank lines if its value is greater than blank lines "After Fields" or "After Function".
   Similar case is also for blank lines "After Class Header" in combination with blank lines "Before Fields" and "Before Function".
   
   So proposal seems to be that settings for class start and end should have higher priority than the other settings.
   Right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] zeleznypa commented on issue #4611: PHP code format - no new line after last method

Posted by "zeleznypa (via GitHub)" <gi...@apache.org>.
zeleznypa commented on issue #4611:
URL: https://github.com/apache/netbeans/issues/4611#issuecomment-1489903655

   @tmysik Thanks so much ❤️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on issue #4611: PHP code format - no new line after last method

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on issue #4611:
URL: https://github.com/apache/netbeans/issues/4611#issuecomment-1490004752

   @zeleznypa Not me, I just clicked the Merge button ;)
   
   @junichi11 is the right guy to thank to, he is implementing all the PHP support in NetBeans (not only) these days. Thanks a lot, Junichi!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists